MattTheTekie/devilutionX
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

address performance-unnecessary-value-param

Browse source 
clang-tidy warns about the unnecessary copy for these params

Could also potentially use std::make_unique if the Action constructor wasn't declared private?
This commit is contained in:
Andrew James 2022-01-08 00:28:45 +11:00 • committed by Anders Jenbo
commit 8fa04ce651
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Source/options.cpp
View file

@ -1166,7 +1166,7 @@ bool KeymapperOptions::Action::SetValue(int value)
void KeymapperOptions::AddAction(string_view key, string_view name, string_view description, int defaultKey, std::function<void()> action, std::function<bool()> enable, int index)
{
actions.push_back(std::unique_ptr<Action>(new Action(key, name, description, defaultKey, action, enable, index)));
actions.push_back(std::unique_ptr<Action>(new Action(key, name, description, defaultKey, std::move(action), std::move(enable), index)));
}
void KeymapperOptions::KeyPressed(int key) const