MattTheTekie/devilutionX
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Refactor OperateShrineSparkling to use Point

Browse source 
Also added documentation about what the function does.
This commit is contained in:
ephphatha 2021-06-09 23:41:09 +10:00 • committed by Anders Jenbo
commit c2cf2f8b59
1 changed files with 9 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Source/objects.cpp
View file

@ -4078,7 +4078,13 @@ bool OperateShrineMendicant(int pnum)
return true;
}
bool OperateShrineSparkling(int pnum, int x, int y)
/**
* @brief Grants experience to the player based on their current level while also triggering a magic trap
* @param pnum The player that activated the shrine
* @param spawnPosition The trap results in casting flash from this location targeting the player
* @return false if the current player didn't activate the shrine (to avoid doubling the effect), true otherwise
*/
bool OperateShrineSparkling(int pnum, Point spawnPosition)
{
if (deltaload)
return false;
@ -4088,7 +4094,7 @@ bool OperateShrineSparkling(int pnum, int x, int y)
AddPlrExperience(MyPlayerId, Players[MyPlayerId]._pLevel, 1000 * currlevel);
AddMissile(
{ x, y },
spawnPosition,
Players[MyPlayerId].position.tile,
Players[MyPlayerId]._pdir,
MIS_FLASH,
@ -4336,7 +4342,7 @@ void OperateShrine(int pnum, int i, _sfx_id sType)
return;
break;
case ShrineSparkling:
if (!OperateShrineSparkling(pnum, Objects[i].position.x, Objects[i].position.y))
if (!OperateShrineSparkling(pnum, Objects[i].position))
return;
break;
case ShrineTown: